Issue 150000043: code review 150000043: go.image/cmd/webp-manual-test: new program to test Go's WEBP

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 150000043: code review 150000043: go.image/cmd/webp-manual-test: new program to test Go's WEBP (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 7 months ago

Reviewers:
r

CC:
r, skal, golang-codereviews

Visibility:
Public.

Description

go.image/cmd/webp-manual-test: new program to test Go's WEBP compatibility with the C libwebp implementation. Current status: 104 PASS, 5 FAIL, 109 TOTAL Of those 5 failures, 3 are because Go doesn't support lossy-with-alpha yet, and the other 2 (lossless_vec_2_13.webp, lossy_extreme_probabilities.webp) look like genuine bugs.

Patch Set 1 #

Patch Set 2 : diff -r c5467ab5f876ed4400edfc8419f29a4c14cdd3a7 https://code.google.com/p/go.image #

Patch Set 3 : diff -r c5467ab5f876ed4400edfc8419f29a4c14cdd3a7 https://code.google.com/p/go.image #

Total comments: 2

Patch Set 4 : diff -r c5467ab5f876ed4400edfc8419f29a4c14cdd3a7 https://code.google.com/p/go.image #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -0 lines)			Patch
	A	cmd/webp-manual-test/main.go	View	1 2 3	1 chunk	+165 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image

9 years, 7 months ago (2014-09-24 07:36:20 UTC) #1

skal

(looks good overall, for the testing side) https://codereview.appspot.com/150000043/diff/40001/cmd/webp-manual-test/main.go File cmd/webp-manual-test/main.go (right): https://codereview.appspot.com/150000043/diff/40001/cmd/webp-manual-test/main.go#newcode152 cmd/webp-manual-test/main.go:152: for y ...

9 years, 7 months ago (2014-09-24 08:00:51 UTC) #2

nigeltao

https://codereview.appspot.com/150000043/diff/40001/cmd/webp-manual-test/main.go File cmd/webp-manual-test/main.go (right): https://codereview.appspot.com/150000043/diff/40001/cmd/webp-manual-test/main.go#newcode152 cmd/webp-manual-test/main.go:152: for y := b.Min.Y; y < b.Max.Y; y += ...

9 years, 7 months ago (2014-09-24 08:22:27 UTC) #3

nigeltao

9 years, 7 months ago (2014-09-24 23:44:40 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=250a212e718a&repo=image ***

go.image/cmd/webp-manual-test: new program to test Go's WEBP
compatibility with the C libwebp implementation.

Current status:
104 PASS, 5 FAIL, 109 TOTAL
Of those 5 failures, 3 are because Go doesn't support lossy-with-alpha
yet, and the other 2 (lossless_vec_2_13.webp,
lossy_extreme_probabilities.webp) look like genuine bugs.

LGTM=r
R=r, pascal.massimino
CC=golang-codereviews
https://codereview.appspot.com/150000043

Expand All Messages | Collapse All Messages