Issue 149570043: code review 149570043: encoding/json: document that embedded interfaces look l...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 149570043: code review 149570043: encoding/json: document that embedded interfaces look l... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
r, gobot

CC:
golang-codereviews, r, iant

Visibility:
Public.

Description

encoding/json: document that embedded interfaces look like non-embedded ones Fixes issue 8386.

Patch Set 1 #

Patch Set 2 : diff -r 38965cf3cec663c0aff7b1ab8fb2c663d592c3df https://code.google.com/p/go/ #

Patch Set 3 : diff -r 38965cf3cec663c0aff7b1ab8fb2c663d592c3df https://code.google.com/p/go/ #

Patch Set 4 : diff -r af10ef093dae05eef832e0b82b5692b43794e1aa https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/encoding/json/encode.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-06 18:44:14 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=fc7f33346bed *** encoding/json: document that embedded interfaces look like non-embedded ones Fixes ...

9 years, 6 months ago (2014-10-06 19:48:22 UTC) #3

gobot

9 years, 6 months ago (2014-10-07 01:44:06 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-amd64-race builder.
See http://build.golang.org/log/6402e6a2a5639f5f029e9fab68ce69532287459b

Expand All Messages | Collapse All Messages