Issue 149540045: code review 149540045: cmd/8l: accept R_386_GOT32 in push instruction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 149540045: code review 149540045: cmd/8l: accept R_386_GOT32 in push instruction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by rsc

Modified:
10 years, 5 months ago

Reviewers:
gobot, iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

cmd/8l: accept R_386_GOT32 in push instruction Fixes issue 8382.

Patch Set 1 #

Patch Set 2 : diff -r 6f838e5073991a6d4621f54c509027c879aa0e1e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6f838e5073991a6d4621f54c509027c879aa0e1e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 53bd565d673636fa6e74e946a868d0264bafa9ae https://code.google.com/p/go/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	src/cmd/8l/asm.c	View	1 2	1 chunk	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 5 months ago (2014-10-06 17:23:41 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=5387586e123e *** cmd/8l: accept R_386_GOT32 in push instruction Fixes issue 8382. LGTM=iant ...

10 years, 5 months ago (2014-10-06 18:17:54 UTC) #3

gobot

10 years, 5 months ago (2014-10-06 18:19:56 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/b86ced026223ae3de74035e1d03eec216655baf3

Expand All Messages | Collapse All Messages