code review 14950045: net: make sure failed Dial returns nil Conn

net: make sure failed Dial returns nil Conn

Fixes issue 6614.

[rsc, 2013-10-18 18:14:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2013-10-18 18:14:40]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-10-18 18:30:28]

LGTM

[mikio, 2013-10-18 18:34:29]

right now rietveld doesn't work well on my browser.

> +func TestErrorNil(t *testing.T) {

also FileConn, FIlePacketConn and FileListener

> +       }
> +
> +}

unnecessary blank line.

[rsc, 2013-10-18 19:35:03]

On Fri, Oct 18, 2013 at 2:34 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> right now rietveld doesn't work well on my browser.
>
> > +func TestErrorNil(t *testing.T) {
>
> also FileConn, FIlePacketConn and FileListener
>

those look fine to me. the things returning pointers do not return errors.

[rsc, 2013-10-18 19:35:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=1e60ffd5933d ***

net: make sure failed Dial returns nil Conn

Fixes issue 6614.

R=golang-dev, bradfitz, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/14950045

[mikio, 2013-10-18 19:39:37]

LGTM

On Sat, Oct 19, 2013 at 4:35 AM, Russ Cox <rsc@golang.org> wrote:

>> also FileConn, FIlePacketConn and FileListener
>
> those look fine to me. the things returning pointers do not return errors.

I mean test cases for such guys but it's okay. Thanks.

[dave_cheney.net, 2013-10-18 21:24:56]

LGTM. Thank you. 



> On 19 Oct 2013, at 5:30, bradfitz@golang.org wrote:
> 
> LGTM
> 
> 
> https://codereview.appspot.com/14950045/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.