Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4749)

Issue 149300046: code review 149300046: syscall: fix Setenv for plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by mischief
Modified:
9 years, 6 months ago
Reviewers:
0intro, bradfitz
CC:
bradfitz, 0intro, golang-codereviews
Visibility:
Public.

Description

syscall: fix Setenv for plan 9 envi needs to be updated during Setenv so the key can be correctly deleted later with Unsetenv. Update issue 8849.

Patch Set 1 #

Patch Set 2 : diff -r 8fc08cc5a7ea5720271e3bf9da2ff5b820fe56ce https://code.google.com/p/go/ #

Patch Set 3 : diff -r 8fc08cc5a7ea5720271e3bf9da2ff5b820fe56ce https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/syscall/env_plan9.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
mischief
Hello bradfitz@golang.org, 0intro@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2014-10-02 07:07:35 UTC) #1
0intro
LGTM Waiting for Brad. I think s/Fixes/Update/ would be more accurate in the description.
9 years, 6 months ago (2014-10-02 07:12:09 UTC) #2
0intro
I believe Brad went to sleep. Submitting it anyway to fix the Plan 9 build.
9 years, 6 months ago (2014-10-02 08:25:37 UTC) #3
0intro
*** Submitted as https://code.google.com/p/go/source/detail?r=7af2b6fa04ee *** syscall: fix Setenv for plan 9 envi needs to be ...
9 years, 6 months ago (2014-10-02 08:26:34 UTC) #4
bradfitz
9 years, 6 months ago (2014-10-02 16:12:00 UTC) #5
LGTM as short-term fix.
 On Oct 2, 2014 1:26 AM, <0intro@gmail.com> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=7af2b6fa04ee ***
>
> syscall: fix Setenv for plan 9
>
> envi needs to be updated during Setenv so the key can be correctly
> deleted later with Unsetenv.
>
> Update issue 8849.
>
> LGTM=0intro
> R=bradfitz, 0intro
> CC=golang-codereviews
> https://codereview.appspot.com/149300046
>
> Committer: David du Colombier <0intro@gmail.com>
>
>
> https://codereview.appspot.com/149300046/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b