Issue 149200043: code review 149200043: [release-branch.go1.3] net: temporarily skip TestAccept...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 149200043: code review 149200043: [release-branch.go1.3] net: temporarily skip TestAccept... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by adg

Modified:
9 years, 7 months ago

Reviewers:
dsymonds

CC:
dsymonds, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.3] net: temporarily skip TestAcceptIgnoreSomeErrors ««« CL 138120043 / 9a36c3ea7015 net: temporarily skip TestAcceptIgnoreSomeErrors Update issue 8662 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/138120043 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r e11f3e56a8bf287cb71262990c5343452c683052 https://code.google.com/p/go #

Patch Set 3 : diff -r e11f3e56a8bf287cb71262990c5343452c683052 https://code.google.com/p/go #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/net/net_windows_test.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello dsymonds (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 7 months ago (2014-09-29 03:48:52 UTC) #1

adg

9 years, 7 months ago (2014-09-29 03:49:46 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=b2974dc26ab7 ***

[release-branch.go1.3] net: temporarily skip TestAcceptIgnoreSomeErrors

««« CL 138120043 / 9a36c3ea7015
net: temporarily skip TestAcceptIgnoreSomeErrors

Update issue 8662

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/138120043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
»»»

LGTM=dsymonds
R=dsymonds
CC=golang-codereviews
https://codereview.appspot.com/149200043

Expand All Messages | Collapse All Messages