Issue 149090043: code review 149090043: go.image/bmp: add a test image for top-down BMPs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 149090043: code review 149090043: go.image/bmp: add a test image for top-down BMPs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 7 months ago

Reviewers:
ruiu

CC:
ruiu, bsiegert, golang-codereviews

Visibility:
Public.

Description

go.image/bmp: add a test image for top-down BMPs.

Patch Set 1 #

Patch Set 2 : diff -r 7886cae12d15437f47bb6ea9ef9150a87e48ef9c https://code.google.com/p/go.image #

Patch Set 3 : diff -r 7886cae12d15437f47bb6ea9ef9150a87e48ef9c https://code.google.com/p/go.image #

Patch Set 4 : diff -r 9d31e3583c83ba397c18a832b890696b5e52041a https://code.google.com/p/go.image #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -21 lines)			Patch
M	bmp/reader_test.go	View	1	3 chunks	+37 lines, -21 lines	0 comments	Download
A	testdata/yellow_rose-small.bmp	View	1	Binary file		0 comments	Download
A	testdata/yellow_rose-small.png	View	1	Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello ruiu@google.com (cc: bsiegert@gmail.com, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image

9 years, 7 months ago (2014-09-26 02:54:40 UTC) #1

nigeltao

9 years, 7 months ago (2014-09-30 23:41:30 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=ec4a7a634f48&repo=image ***

go.image/bmp: add a test image for top-down BMPs.

LGTM=ruiu
R=ruiu
CC=bsiegert, golang-codereviews
https://codereview.appspot.com/149090043

Expand All Messages | Collapse All Messages