Issue 149070043: code review 149070043: cmd/go: add test -o flag to control where test binary i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 149070043: code review 149070043: cmd/go: add test -o flag to control where test binary i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
r

CC:
golang-codereviews, r, iant

Visibility:
Public.

Description

cmd/go: add test -o flag to control where test binary is written While we are here, remove undocumented, meaningless test -file flag. Fixes issue 7724.

Patch Set 1 #

Patch Set 2 : diff -r b811c3bc6cda5e9140e3774304b7cb1270518d6e https://code.google.com/p/go/ #

Patch Set 3 : diff -r b811c3bc6cda5e9140e3774304b7cb1270518d6e https://code.google.com/p/go/ #

Patch Set 4 : diff -r cd24f5ff3db869a41efbf3a83e9e3f55b61460b8 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 49fd34ea89660e182272c8798bb10ee831668763 https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -20 lines)			Patch
M	src/cmd/go/test.bash	View	1 2 3 4	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1 2 3	9 chunks	+35 lines, -17 lines	0 comments	Download
M	src/cmd/go/testflag.go	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-26 16:30:30 UTC) #1

rsc

9 years, 7 months ago (2014-09-26 17:50:10 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=ed23bbff73da ***

cmd/go: add test -o flag to control where test binary is written

While we are here, remove undocumented, meaningless test -file flag.

Fixes issue 7724.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://codereview.appspot.com/149070043

Expand All Messages | Collapse All Messages