Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1625)

Issue 148710043: code review 148710043: runtime: fix memory profiler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dvyukov
Modified:
9 years, 6 months ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

runtime: fix memory profiler There are 3 issues: 1. Skip argument of callers is off by 3, so that all allocations are deep inside of memory profiler. 2. Memory profiling statistics are not updated after runtime.GC. 3. Testing package does not update memory profiling statistics before capturing the profile. Also add an end-to-end test. Fixes issue 8867.

Patch Set 1 #

Patch Set 2 : diff -r a65c023d4ed41be1348d441682a45ba331da8762 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r a65c023d4ed41be1348d441682a45ba331da8762 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r a65c023d4ed41be1348d441682a45ba331da8762 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 8c3f3337f7696bfcb95ab978b5c2782b94431842 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -2 lines) Patch
M src/runtime/mgc0.c View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M src/runtime/mprof.go View 1 1 chunk +1 line, -1 line 0 comments Download
A src/runtime/pprof/mprof_test.go View 1 1 chunk +146 lines, -0 lines 0 comments Download
M src/testing/testing.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 6 months ago (2014-10-08 11:54:16 UTC) #1
dvyukov
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 6 months ago (2014-10-08 12:03:53 UTC) #2
rsc
LGTM
9 years, 6 months ago (2014-10-16 13:51:39 UTC) #3
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=3d61db5c1240 *** runtime: fix memory profiler There are 3 issues: 1. Skip ...
9 years, 6 months ago (2014-10-16 18:11:33 UTC) #4
gobot
9 years, 6 months ago (2014-10-16 18:13:10 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/ce74700a37dece64bd3746fd1d887a7adee3fdc4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b