Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1128)

Issue 14860043: code review 14860043: api: add go1.2.txt, use in tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by adg
Modified:
10 years, 5 months ago
Reviewers:
iant
CC:
golang-dev, iant
Visibility:
Public.

Description

api: add go1.2.txt, use in tests

Patch Set 1 #

Patch Set 2 : diff -r 5916f3b9c15e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/api/run.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 5 months ago (2013-10-18 03:01:50 UTC) #1
adg
the go1.2.txt was too big for mail, see attached On 18 October 2013 12:01, <adg@golang.org> ...
10 years, 5 months ago (2013-10-18 03:03:46 UTC) #2
adg
Here are the additions, minus log/syslog and syscall: pkg archive/zip, func RegisterCompressor(uint16, Compressor) pkg archive/zip, ...
10 years, 5 months ago (2013-10-18 03:05:12 UTC) #3
iant
LGTM On Thu, Oct 17, 2013 at 8:04 PM, Andrew Gerrand <adg@golang.org> wrote: > Here ...
10 years, 5 months ago (2013-10-18 04:02:42 UTC) #4
adg
10 years, 5 months ago (2013-10-18 04:37:15 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=e2e0547ad087 ***

api: add go1.2.txt, use in tests

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/14860043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b