Issue 14830043: code review 14830043: misc/dist: set default go.tools tag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14830043: code review 14830043: misc/dist: set default go.tools tag (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by adg

Modified:
10 years, 6 months ago

Reviewers:
dsymonds

CC:
dsymonds, golang-dev

Visibility:
Public.

Description

misc/dist: set default go.tools tag Fixes issue 6607.

Patch Set 2 : diff -r 67ccd5be690e https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	misc/dist/bindist.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello dsymonds (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-10-18 01:47:28 UTC) #1

dsymonds

LGTM https://codereview.appspot.com/14830043/diff/1/misc/dist/bindist.go File misc/dist/bindist.go (right): https://codereview.appspot.com/14830043/diff/1/misc/dist/bindist.go#newcode52 misc/dist/bindist.go:52: defaultToolTag = "9e246fa49449" a short comment might be ...

10 years, 6 months ago (2013-10-18 01:48:39 UTC) #2

adg

10 years, 6 months ago (2013-10-18 01:51:31 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5916f3b9c15e ***

misc/dist: set default go.tools tag

Fixes issue 6607.

R=dsymonds
CC=golang-dev
https://codereview.appspot.com/14830043

Expand All Messages | Collapse All Messages