Issue 148300043: code review 148300043: [release-branch.go1.3] go.tools/present: allow intentio...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 148300043: code review 148300043: [release-branch.go1.3] go.tools/present: allow intentio... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by adg

Modified:
9 years, 7 months ago

Reviewers:
dsymonds

CC:
dsymonds, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.3] go.tools/present: allow intentionally empty parameters ««« CL 105070043 / 1e6e75afb0cd go.tools/present: allow intentionally empty parameters Fixes issue 7613. LGTM=r R=adg, r CC=golang-codereviews https://codereview.appspot.com/105070043 Committer: Rob Pike <r@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 891999801382b74df05f72e96333662794047255 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 891999801382b74df05f72e96333662794047255 https://code.google.com/p/go.tools #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
M	present/code.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	present/doc.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	present/image.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello dsymonds (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

9 years, 7 months ago (2014-09-29 03:53:54 UTC) #1

adg

9 years, 7 months ago (2014-09-29 03:55:44 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=6a0d2cdcc07c&repo=tools ***

[release-branch.go1.3] go.tools/present: allow intentionally empty parameters

««« CL 105070043 / 1e6e75afb0cd
go.tools/present: allow intentionally empty parameters

Fixes issue 7613.

LGTM=r
R=adg, r
CC=golang-codereviews
https://codereview.appspot.com/105070043

Committer: Rob Pike <r@golang.org>
»»»

LGTM=dsymonds
R=dsymonds
CC=golang-codereviews
https://codereview.appspot.com/148300043

Expand All Messages | Collapse All Messages