Issue 148190043: code review 148190043: go.blog: add Docker article

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 148190043: code review 148190043: go.blog: add Docker article (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by adg

Modified:
9 years, 7 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r b2de5fd8dd58227ab02bc6d9d0fd89114f5f999b https://code.google.com/p/go.blog #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -0 lines)			Patch
	A	content/docker.article	View	1	1 chunk	+201 lines, -0 lines	0 comments	Download
	A	content/docker-outyet.png	View		Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.blog

9 years, 7 months ago (2014-09-26 21:33:30 UTC) #1

LGTM https://codereview.appspot.com/148190043/diff/1/content/docker.article File content/docker.article (right): https://codereview.appspot.com/148190043/diff/1/content/docker.article#newcode35 content/docker.article:35: Create a file named `Dockerfile` in the outyet ...

9 years, 7 months ago (2014-09-26 21:36:27 UTC) #2

adg

9 years, 7 months ago (2014-09-26 21:41:39 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=2d846e429490&repo=blog ***

go.blog: add Docker article

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/148190043

https://codereview.appspot.com/148190043/diff/1/content/docker.article
File content/docker.article (right):

https://codereview.appspot.com/148190043/diff/1/content/docker.article#newcode35
content/docker.article:35: Create a file named `Dockerfile` in the outyet
directory with the following contents:
On 2014/09/26 21:36:26, r wrote:
> `outyet`

Done.

https://codereview.appspot.com/148190043/diff/1/content/docker.article#newcod...
content/docker.article:135: that make it easy to spin up a Virtual Machine
running an arbitrary Docker
On 2014/09/26 21:36:26, r wrote:
> why Virtual Machine in caps?

Done.

https://codereview.appspot.com/148190043/diff/1/content/docker.article#newcod...
content/docker.article:136: container. On startup, a program running on the
instance reads a configuration
On 2014/09/26 21:36:26, r wrote:
> start sentence on new line

Done.

https://codereview.appspot.com/148190043/diff/1/content/docker.article#newcod...
content/docker.article:200: To learn more about Docker and
[[http://cloud.google.com/compute][Google Compute Engine]], see the
[[https://cloud.google.com/compute/docs/containers/container_vms][Container-optimized
VMs page]] and the
[[https://registry.hub.docker.com/u/google/docker-registry/][google/docker-registry
Docker Hub repository]].
On 2014/09/26 21:36:26, r wrote:
> unmanageeeeeeably long line

Done.

Expand All Messages | Collapse All Messages