Issue 14815043: code review 14815043: net/url: fix regression when serializing relative URLs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14815043: code review 14815043: net/url: fix regression when serializing relative URLs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by bradfitz

Modified:
10 years, 6 months ago

Reviewers:
r, dsymonds

CC:
golang-dev, dsymonds, r

Visibility:
Public.

Description

net/url: fix regression when serializing relative URLs Only add a slash to path if it's a separator between a host and path. Fixes issue 6609

Patch Set 1 #

Patch Set 2 : diff -r 9620ff603344 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9620ff603344 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9620ff603344 https://go.googlecode.com/hg/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/pkg/net/url/url.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/net/url/url_test.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 6 months ago (2013-10-17 22:14:08 UTC) #1

bradfitz

10 years, 6 months ago (2013-10-17 23:06:48 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=67ccd5be690e ***

net/url: fix regression when serializing relative URLs

Only add a slash to path if it's a separator between
a host and path.

Fixes issue 6609

R=golang-dev, dsymonds, r
CC=golang-dev
https://codereview.appspot.com/14815043

Expand All Messages | Collapse All Messages