Issue 148040043: code review 148040043: net/http: check for CloseWrite interface, not TCPConn i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 148040043: code review 148040043: net/http: check for CloseWrite interface, not TCPConn i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by bradfitz

Modified:
9 years, 7 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

net/http: check for CloseWrite interface, not TCPConn implementation Fixes Issue 8724

Patch Set 1 #

Patch Set 2 : diff -r 1e2b51e32781fe475a580ffc8a7776507dfec1d5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1e2b51e32781fe475a580ffc8a7776507dfec1d5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f23e0b9b3d2077b4875b682bb8689344c81e62da https://go.googlecode.com/hg/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
M	src/net/http/export_test.go	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/net/http/serve_test.go	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	src/net/http/server.go	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 7 months ago (2014-09-24 17:52:01 UTC) #1

bradfitz

9 years, 7 months ago (2014-09-25 00:01:57 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e3263cbf8a61 ***

net/http: check for CloseWrite interface, not TCPConn implementation

Fixes Issue 8724

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/148040043

Expand All Messages | Collapse All Messages