Issue 148020043: code review 148020043: go.image/bmp: support decoding 32-bit BMPs, as well as ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 148020043: code review 148020043: go.image/bmp: support decoding 32-bit BMPs, as well as ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 7 months ago

Reviewers:
ruiu, bsiegert

CC:
bsiegert, golang-codereviews

Visibility:
Public.

Description

go.image/bmp: support decoding 32-bit BMPs, as well as top-down BMPs. Tested manually, from "dwebp -bmp" output. dwebp comes from https://developers.google.com/speed/webp/download

Patch Set 2 : diff -r c5467ab5f876ed4400edfc8419f29a4c14cdd3a7 https://code.google.com/p/go.image #

Patch Set 3 : diff -r c5467ab5f876ed4400edfc8419f29a4c14cdd3a7 https://code.google.com/p/go.image #

Total comments: 1

Patch Set 4 : diff -r 7a8e2591696101dc29f11146976bccb4dd3c5aea https://code.google.com/p/go.image #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -39 lines)			Patch
	M	bmp/reader.go	View	1 2 3	5 chunks	+77 lines, -39 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image

9 years, 7 months ago (2014-09-24 08:29:00 UTC) #1

bsiegert

LGTM https://codereview.appspot.com/148020043/diff/40001/bmp/reader.go File bmp/reader.go (left): https://codereview.appspot.com/148020043/diff/40001/bmp/reader.go#oldcode29 bmp/reader.go:29: // decodePaletted reads an 8 bit-per-pixel BMP image ...

9 years, 7 months ago (2014-09-25 12:22:13 UTC) #2

nigeltao

*** Submitted as https://code.google.com/p/go/source/detail?r=7886cae12d15&repo=image *** go.image/bmp: support decoding 32-bit BMPs, as well as top-down BMPs. ...

9 years, 7 months ago (2014-09-26 01:12:26 UTC) #3

ruiu

9 years, 7 months ago (2014-09-26 01:16:34 UTC) #4

Message was sent while issue was closed.

Is there any reason to not add a test with the BMP file
that you used for manual testing?

Expand All Messages | Collapse All Messages