code review 14793043: runtime: correct test for when to poll network

runtime: correct test for when to poll network

Fixes issue 6610.

[iant, 2013-10-17 18:56:24]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[khr1, 2013-10-17 18:57:03]

LGTM.


On Thu, Oct 17, 2013 at 11:56 AM, <iant@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> runtime: correct test for when to poll network
>
> Fixes issue 6610.
>
> Please review this at
https://codereview.appspot.**com/14793043/<https://codereview.appspot.com/147...
>
> Affected files (+1, -1 lines):
>   M src/pkg/runtime/proc.c
>
>
> Index: src/pkg/runtime/proc.c
> ==============================**==============================**=======
> --- a/src/pkg/runtime/proc.c
> +++ b/src/pkg/runtime/proc.c
> @@ -2382,7 +2382,7 @@
>                 // poll network if not polled for more than 10ms
>                 lastpoll = runtime·atomicload64(&runtime·**
> sched.lastpoll);
>                 now = runtime·nanotime();
> -               if(lastpoll != 0 && lastpoll + 10*1000*1000 > now) {
> +               if(lastpoll != 0 && lastpoll + 10*1000*1000 < now) {
>                         runtime·cas64(&runtime·sched.**lastpoll,
> lastpoll, now);
>                         gp = runtime·netpoll(false);  // non-blocking
>                         if(gp) {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[iant, 2013-10-17 18:57:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=9620ff603344 ***

runtime: correct test for when to poll network

Fixes issue 6610.

R=golang-dev, khr
CC=golang-dev
https://codereview.appspot.com/14793043