Issue 147390043: code review 147390043: compress/zlib: mention that NewReaderDict can return Er...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 147390043: code review 147390043: compress/zlib: mention that NewReaderDict can return Er... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
iant

CC:
golang-codereviews, iant, ruiu

Visibility:
Public.

Description

compress/zlib: mention that NewReaderDict can return ErrDictionary Fixes issue 7935.

Patch Set 1 #

Patch Set 2 : diff -r cd24f5ff3db869a41efbf3a83e9e3f55b61460b8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f804c5bc096d3a87bba0dd7ed74aae850b93873e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8cb7f59e4f1b80c9d7824bda4f2c1a64409bff7c https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/compress/zlib/reader.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, ruiu@google.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-30 16:08:55 UTC) #1

rsc

9 years, 7 months ago (2014-09-30 16:30:38 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d539076652f8 ***

compress/zlib: mention that NewReaderDict can return ErrDictionary

Fixes issue 7935.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, ruiu
https://codereview.appspot.com/147390043

Expand All Messages | Collapse All Messages