Issue 147380044: code review 147380044: [release-branch.go1.3] nacltest.bash: unset GOROOT

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 147380044: code review 147380044: [release-branch.go1.3] nacltest.bash: unset GOROOT (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
r

CC:
golang-codereviews, r, bradfitz, iant

Visibility:
Public.

Description

[release-branch.go1.3] nacltest.bash: unset GOROOT The GOROOT baked into the go command being run is correct. The GOROOT in the environment may not be. Remove it. Fixes nacltest.bash if you have GOROOT set elsewhere. This is already fixed in the default branch.

Patch Set 1 #

Patch Set 2 : diff -r 6ee8ec277a21 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6ee8ec277a21 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6ee8ec277a21 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/nacltest.bash	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: bradfitz, iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-09-30 16:06:21 UTC) #1

rsc

9 years, 6 months ago (2014-09-30 16:34:41 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=19005c375ee5 ***

[release-branch.go1.3] nacltest.bash: unset GOROOT

The GOROOT baked into the go command being run is correct.
The GOROOT in the environment may not be. Remove it.

Fixes nacltest.bash if you have GOROOT set elsewhere.

This is already fixed in the default branch.

LGTM=r
R=golang-codereviews, r
CC=bradfitz, golang-codereviews, iant
https://codereview.appspot.com/147380044

Expand All Messages | Collapse All Messages