Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(510)

Issue 147320043: code review 147320043: crypto/x509: add OpenELEC system root location. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dfc
Modified:
9 years, 6 months ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

crypto/x509: add OpenELEC system root location. Fixes issue 8349.

Patch Set 1 #

Patch Set 2 : diff -r 8f36a32a9d036f86fb956c8538142eb384bd1a4a https://code.google.com/p/go #

Patch Set 3 : diff -r b4f1ec3e4cc182086af8a30c19c24f0575339184 https://code.google.com/p/go #

Patch Set 4 : diff -r b4f1ec3e4cc182086af8a30c19c24f0575339184 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/crypto/x509/root_unix.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
rsc
LGTM
9 years, 6 months ago (2014-09-30 11:26:30 UTC) #1
rsc
ping dfc; please submit
9 years, 6 months ago (2014-10-03 17:00:37 UTC) #2
dfc
Will do. I was hoping the OP of the issue would respond, but it's been ...
9 years, 6 months ago (2014-10-03 22:04:41 UTC) #3
dfc
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2014-10-03 22:09:34 UTC) #4
dfc
*** Submitted as https://code.google.com/p/go/source/detail?r=d4904f349bc8 *** crypto/x509: add OpenELEC system root location. Fixes issue 8349. LGTM=rsc ...
9 years, 6 months ago (2014-10-03 22:09:56 UTC) #5
gobot
This CL appears to have broken the plan9-amd64-aram builder. See http://build.golang.org/log/ed8f12a625beb27f571b5421d7bd8dd98bff919a
9 years, 6 months ago (2014-10-03 22:13:07 UTC) #6
dfc
not reallty --- FAIL: TestRemoveAllRace (0.14s) os_test.go:1449: unexpected error: *os.PathError, "remove /tmp/issue848976529: remove issue848976529: no ...
9 years, 6 months ago (2014-10-03 22:15:20 UTC) #7
rsc
9 years, 6 months ago (2014-10-03 22:43:04 UTC) #8
Fwiw I think he did.

On Friday, October 3, 2014, Dave Cheney <dave@cheney.net> wrote:

> Will do. I was hoping the OP of the issue would respond, but it's been
> a few days now.
>
> On Sat, Oct 4, 2014 at 3:00 AM,  <rsc@golang.org <javascript:;>> wrote:
> > ping dfc; please submit
> >
> >
> > https://codereview.appspot.com/147320043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b