Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(809)

Issue 147220043: code review 147220043: test: migrate remaining tests to run.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by josharian
Modified:
9 years, 4 months ago
Reviewers:
rsc, bradfitz
CC:
golang-codereviews
Visibility:
Public.

Description

test: migrate remaining tests to run.go Finishes the work started in CL 144630044. * bug248 was split into a rundir half (bug248) and an errorcheckdir half (bug248b). * bug302, bug345, bug369, and bug429 were ported from bash commands to run scripts. bug369 remains disabled. * bug395 is a test for issue 1909, which is still open. It is marked as skip now and will be usable with compile with run.go when issue 1909 is fixed. Update issue 1909 Fixes issue 4139.

Patch Set 1 #

Patch Set 2 : diff -r a7b4f8b35fa7212e882f2695f410d0b59a7a7d80 https://code.google.com/p/go #

Patch Set 3 : diff -r a7b4f8b35fa7212e882f2695f410d0b59a7a7d80 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -272 lines) Patch
M test/bugs/bug395.go View 1 2 chunks +3 lines, -4 lines 0 comments Download
M test/fixedbugs/bug248.go View 1 1 chunk +2 lines, -10 lines 0 comments Download
M test/fixedbugs/bug248.dir/bug0.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug248.dir/bug1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug248b.go View 1 1 chunk +2 lines, -10 lines 0 comments Download
M test/fixedbugs/bug248b.dir/bug0.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug248b.dir/bug1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug248b.dir/bug3.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/fixedbugs/bug302.go View 1 1 chunk +43 lines, -4 lines 0 comments Download
M test/fixedbugs/bug345.go View 1 1 chunk +43 lines, -5 lines 0 comments Download
M test/fixedbugs/bug369.go View 1 2 chunks +34 lines, -42 lines 0 comments Download
M test/fixedbugs/bug369.dir/main.go View 1 3 chunks +4 lines, -12 lines 0 comments Download
M test/fixedbugs/bug429.go View 1 1 chunk +2 lines, -4 lines 0 comments Download
A test/fixedbugs/bug429_run.go View 1 1 chunk +33 lines, -0 lines 0 comments Download
R test/golden.out View 1 1 chunk +0 lines, -24 lines 0 comments Download
R test/run View 1 1 chunk +0 lines, -138 lines 0 comments Download
M test/run.go View 1 2 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 2
josharian
Hello rsc@golang.org, bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2014-09-26 20:42:23 UTC) #1
josharian
9 years, 6 months ago (2014-09-26 20:44:46 UTC) #2
A large but boring CL. Changes to run.go will need updating once CL 144630044
has been submitted.

Not tested on Windows, but I think I've done the path handling carefully enough.

Mailed now in case you want a head start on it. I'll update + ping once CL
144630044 is in.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b