Issue 147210043: code review 147210043: flag: allow CommandLine's Usage function to be set

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 147210043: code review 147210043: flag: allow CommandLine's Usage function to be set (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by r

Modified:
9 years, 7 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

flag: allow CommandLine's Usage function to be set Fixes issue 7779.

Patch Set 1 #

Patch Set 2 : diff -r d62cdebe7513197cbf70b87bbade7154d4359a55 https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
	M	src/flag/flag.go	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download
	M	src/flag/flag_test.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-26 18:24:50 UTC) #1

rsc

LGTM Probably the doc comment for var Usage should say when it is called.

9 years, 7 months ago (2014-09-26 18:49:48 UTC) #2

9 years, 7 months ago (2014-09-26 19:33:10 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0f8fd4e12ee5 ***

flag: allow CommandLine's Usage function to be set

Fixes issue 7779.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/147210043

Expand All Messages | Collapse All Messages