Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1894)

Issue 147170043: code review 147170043: cmd/go: re-resolve and check vcs roots during go get -u (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rsc
Modified:
9 years, 7 months ago
Reviewers:
iant
CC:
golang-codereviews, iant, adg, niemeyer, r
Visibility:
Public.

Description

cmd/go: re-resolve and check vcs roots during go get -u If you do 'go get -u rsc.io/pdf' and then rsc.io/pdf's redirect changes to point somewhere else, after this CL a later 'go get -u rsc.io/pdf' will tell you that. Fixes issue 8548.

Patch Set 1 #

Patch Set 2 : diff -r fa76e83936542363533d26300d9e1a95013aecee https://code.google.com/p/go/ #

Patch Set 3 : diff -r fa76e83936542363533d26300d9e1a95013aecee https://code.google.com/p/go/ #

Patch Set 4 : diff -r 39d7b8f3a599a761b1ea21cf93fc615d9ca2c2da https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -6 lines) Patch
M src/cmd/go/get.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/cmd/go/test.bash View 1 1 chunk +50 lines, -0 lines 0 comments Download
M src/cmd/go/vcs.go View 1 2 4 chunks +73 lines, -6 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-codereviews@googlegroups.com (cc: adg, iant, n13m3y3r@gmail.com, r), I'd like you to review this change to ...
9 years, 7 months ago (2014-09-25 21:00:45 UTC) #1
rsc
If someone (Gustavo?) wants to give me the code for bzr and the test invocation, ...
9 years, 7 months ago (2014-09-25 21:01:15 UTC) #2
iant
LGTM
9 years, 7 months ago (2014-09-26 15:15:04 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=cd24f5ff3db8 *** cmd/go: re-resolve and check vcs roots during go get -u ...
9 years, 7 months ago (2014-09-26 16:10:18 UTC) #4
niemeyer
9 years, 7 months ago (2014-09-27 03:30:18 UTC) #5
On Thu, Sep 25, 2014 at 6:01 PM, Russ Cox <rsc@golang.org> wrote:
> If someone (Gustavo?) wants to give me the code for bzr and the test
> invocation, I'll add it to this CL. Otherwise I am happy to mark this fixed
> without bzr support.

Sorry, I didn't catch this in time. I'll have a look at it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b