Issue 147150043: code review 147150043: cmd/go: install dependencies for 'go build -i' on a command

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 147150043: code review 147150043: cmd/go: install dependencies for 'go build -i' on a command (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
r

CC:
golang-codereviews, r, iant

Visibility:
Public.

Description

cmd/go: install dependencies for 'go build -i' on a command Fixes issue 8242.

Patch Set 1 #

Patch Set 2 : diff -r 01d55b07c9201f0620944fc6bd1cb2a9723aa8b8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 01d55b07c9201f0620944fc6bd1cb2a9723aa8b8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 10acb79292cc6b94294415a94fc4d15a188ed882 https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -47 lines)			Patch
	M	src/cmd/go/build.go	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
	M	src/cmd/go/test.bash	View	1	13 chunks	+72 lines, -42 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-25 19:08:37 UTC) #1

rsc

9 years, 7 months ago (2014-09-25 19:57:58 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fa76e8393654 ***

cmd/go: install dependencies for 'go build -i' on a command

Fixes issue 8242.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://codereview.appspot.com/147150043

Expand All Messages | Collapse All Messages