Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(952)

Issue 14695044: code review 14695044: runtime: remove nomemprof (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by dvyukov
Modified:
10 years, 5 months ago
Reviewers:
rsc
CC:
golang-dev, minux1, rsc
Visibility:
Public.

Description

runtime: remove nomemprof Nomemprof seems to be unneeded now, there is no recursion. If the recursion will be re-introduced, it will break loudly by deadlocking. Fixes issue 6566.

Patch Set 1 #

Patch Set 2 : diff -r 3d1fd5df05dd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 3d1fd5df05dd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 5746e3a5443b https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/pkg/runtime/mprof.goc View 1 4 chunks +0 lines, -10 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 5 months ago (2013-10-15 08:29:05 UTC) #1
minux1
consider add a test?
10 years, 5 months ago (2013-10-15 11:26:50 UTC) #2
dvyukov
it seems to be non-trivial any ideas how a good non-flaky test that actually tests ...
10 years, 5 months ago (2013-10-15 11:30:18 UTC) #3
rsc
LGTM I don't understand how, but this appears to fix issue 6592 as well.
10 years, 5 months ago (2013-10-17 15:34:16 UTC) #4
minux1
On Oct 15, 2013 7:30 AM, "Dmitry Vyukov" <dvyukov@google.com> wrote: > it seems to be ...
10 years, 5 months ago (2013-10-17 15:39:58 UTC) #5
rsc
it is okay not to have a test for this.
10 years, 5 months ago (2013-10-17 15:47:58 UTC) #6
dvyukov
10 years, 5 months ago (2013-10-18 06:45:40 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=35d5bae6aac8 ***

runtime: remove nomemprof
Nomemprof seems to be unneeded now, there is no recursion.
If the recursion will be re-introduced, it will break loudly by deadlocking.
Fixes issue 6566.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/14695044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b