Issue 146910043: code review 146910043: vp8l: update comments to match latest spec.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 146910043: code review 146910043: vp8l: update comments to match latest spec. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 7 months ago

Reviewers:
robsc

CC:
robsc, golang-codereviews

Visibility:
Public.

Description

vp8l: update comments to match latest spec. The spec change is at https://gerrit.chromium.org/gerrit/#/c/71605/

Patch Set 1 #

Patch Set 2 : diff -r e492ffa4cad4d945baf6c597b52a306618e6f80a https://code.google.com/p/go.image #

Patch Set 3 : diff -r e492ffa4cad4d945baf6c597b52a306618e6f80a https://code.google.com/p/go.image #

Patch Set 4 : diff -r e492ffa4cad4d945baf6c597b52a306618e6f80a https://code.google.com/p/go.image #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -11 lines)			Patch
	M	vp8l/decode.go	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
	M	vp8l/transform.go	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello robsc@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image

9 years, 7 months ago (2014-09-22 01:55:26 UTC) #1

robsc

On 2014/09/22 01:55:26, nigeltao wrote: > Hello mailto:robsc@google.com (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...

9 years, 7 months ago (2014-09-22 02:03:23 UTC) #2

nigeltao

9 years, 7 months ago (2014-09-22 02:53:00 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=c5467ab5f876&repo=image ***

vp8l: update comments to match latest spec.

The spec change is at
https://gerrit.chromium.org/gerrit/#/c/71605/

LGTM=robsc
R=robsc
CC=golang-codereviews
https://codereview.appspot.com/146910043

Expand All Messages | Collapse All Messages