Issue 146670043: code review 146670043: net/rpc: shut down connection if gob has error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 146670043: code review 146670043: net/rpc: shut down connection if gob has error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by r

Modified:
9 years, 7 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

net/rpc: shut down connection if gob has error The nicest solution would be to buffer the message and only write it if it encodes correctly, but that adds considerable memory and CPU overhead for a very rare condition. Instead, we just shut down the connection if this happens. Fixes issue 7689.

Patch Set 1 #

Patch Set 2 : diff -r 5cf5d1f289a7c32de62e461f81d16fd4f4bf76ca https://code.google.com/p/go #

Patch Set 3 : diff -r 5cf5d1f289a7c32de62e461f81d16fd4f4bf76ca https://code.google.com/p/go #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	src/net/rpc/server.go	View	1 2	3 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 7 months ago (2014-10-01 19:51:24 UTC) #1

9 years, 7 months ago (2014-10-01 20:18:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=db9fe0162862 ***

net/rpc: shut down connection if gob has error
The nicest solution would be to buffer the message and only write
it if it encodes correctly, but that adds considerable memory and
CPU overhead for a very rare condition. Instead, we just shut
down the connection if this happens.
Fixes issue 7689.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/146670043

Expand All Messages | Collapse All Messages