Issue 146470043: code review 146470043: net: fix misleading package comment example

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 146470043: code review 146470043: net: fix misleading package comment example (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by bradfitz

Modified:
9 years, 6 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

net: fix misleading package comment example Fixes Issue 8607

Patch Set 1 #

Patch Set 2 : diff -r 3d8bc2ff5bcfcc766f9388c47e8a1f162ae57522 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3d8bc2ff5bcfcc766f9388c47e8a1f162ae57522 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 502bc645846ac98aa2c51f2eba930e045aa7b0e9 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 7ed4a9feea2c22307929b43da7bbaf5f8b9ded42 https://go.googlecode.com/hg/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/net/net.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 6 months ago (2014-09-29 18:54:38 UTC) #1

bradfitz

9 years, 6 months ago (2014-09-29 19:24:10 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=598ab781a39e ***

net: fix misleading package comment example

Fixes Issue 8607

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/146470043

Expand All Messages | Collapse All Messages