code review 14639044: net: make TestDNSThreadLimit execute at the end of tests

net: make TestDNSThreadLimit execute at the end of tests

Because TestDNSThreadLimit consumes tons of file descriptors and
makes other tests flaky when CGO_ENABLE=0 or being with netgo tag.

Fixes issue 6580.

[mikio, 2013-10-13 11:03:46]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2013-12-10 11:00:07]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-12-10 11:23:46]

I would like to see it documented or decided that the z_last_test.go thing is
actually a reliable way to control the ordering of tests.

[mikio, 2013-12-10 11:29:05]

+adg


On Tue, Dec 10, 2013 at 8:23 PM,  <bradfitz@golang.org> wrote:
> I would like to see it documented or decided that the z_last_test.go
> thing is actually a reliable way to control the ordering of tests.
>
>
> https://codereview.appspot.com/14639044/

[mikio, 2013-12-13 06:15:22]

adg,

any thoughts? for now net/http and net packages need some way to put
off the execution of big eater test cases.

On Tue, Dec 10, 2013 at 8:29 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> +adg
>
>
> On Tue, Dec 10, 2013 at 8:23 PM,  <bradfitz@golang.org> wrote:
>> I would like to see it documented or decided that the z_last_test.go
>> thing is actually a reliable way to control the ordering of tests.
>>
>>
>> https://codereview.appspot.com/14639044/

[adg, 2013-12-16 02:07:06]

I don't understand how this CL does what the description says.
Aren't you just removing tests?

[mikio, 2013-12-16 02:36:15]

> I don't understand how this CL does what the description says.
> Aren't you just removing tests?

Just did hg cp dialgoogle_test.go z_last_test.go, then modified z_last_test.go
to preserve modification history. Does it matter?

So the point would be... could we depend on the testing package feature (for now
it's undocumented and Brad wants to make sure whether it`s a reliable way) to
put off the big eater test cases by twiddling test case file names starting with
"z_" and/or "9_"?

For example:
https://code.google.com/p/go/source/browse/src/pkg/net/http/z_last_test.go

[minux1, 2013-12-16 02:39:21]

On Sun, Dec 15, 2013 at 9:36 PM, <mikioh.mikioh@gmail.com> wrote:

> I don't understand how this CL does what the description says.
>> Aren't you just removing tests?
>>
>
> Just did hg cp dialgoogle_test.go z_last_test.go, then modified
> z_last_test.go to preserve modification history. Does it matter?
>
I don't understand why on the rietveld, all your changes are deletion of
code.

>
> So the point would be... could we depend on the testing package feature
> (for now it's undocumented and Brad wants to make sure whether it`s a
> reliable way) to put off the big eater test cases by twiddling test case
> file names starting with "z_" and/or "9_"?

[mikio, 2013-12-16 02:46:40]

On 2013/12/16 02:39:21, minux wrote:

> > Just did hg cp dialgoogle_test.go z_last_test.go, then modified
> > z_last_test.go to preserve modification history. Does it matter?
> >
> I don't understand why on the rietveld, all your changes are deletion of
> code.

Not sure, diff shows some diffs, probably that chunk is still in-flight in stats
gatherer.

[adg, 2013-12-17 00:31:43]

LGTM

[mikio, 2013-12-18 04:04:26]

On 2013/12/17 00:31:43, adg wrote:
> LGTM

Thanks, confirmed that cmd/go/pkg.go uses sort.Strings, will submit.

[mikio, 2013-12-18 04:05:54]

*** Submitted as https://code.google.com/p/go/source/detail?r=6a8d10f551ea ***

net: make TestDNSThreadLimit execute at the end of tests

Because TestDNSThreadLimit consumes tons of file descriptors and
makes other tests flaky when CGO_ENABLE=0 or being with netgo tag.

Fixes issue 6580.

R=golang-dev, bradfitz, adg, minux.ma
CC=golang-dev
https://codereview.appspot.com/14639044