Issue 14638043: code review 14638043: net: add test cases for the both of netgo, cgo DNS lookups

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14638043: code review 14638043: net: add test cases for the both of netgo, cgo DNS lookups (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by mikio

Modified:
10 years, 4 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

net: add test cases for the both of netgo, cgo DNS lookups Update issue 4078

Patch Set 1 : diff -r 9f67b2b6ee3a https://code.google.com/p/go #

Total comments: 4

Patch Set 2 : diff -r a55b71fd16a5 https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	A	src/pkg/net/cgo_unix_test.go	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
	A	src/pkg/net/netgo_unix_test.go	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-10-13 07:28:05 UTC) #1

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 6 months ago (2013-10-14 00:27:14 UTC) #2

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 4 months ago (2013-12-10 11:00:28 UTC) #3

rsc

LGTM https://codereview.appspot.com/14638043/diff/56001/src/pkg/net/cgo_unix_test.go File src/pkg/net/cgo_unix_test.go (right): https://codereview.appspot.com/14638043/diff/56001/src/pkg/net/cgo_unix_test.go#newcode12 src/pkg/net/cgo_unix_test.go:12: func TestCGoLookupIP(t *testing.T) { s/CGo/Cgo/ https://codereview.appspot.com/14638043/diff/56001/src/pkg/net/netgo_unix_test.go File src/pkg/net/netgo_unix_test.go ...

10 years, 4 months ago (2013-12-18 18:02:46 UTC) #5

mikio

10 years, 4 months ago (2013-12-18 22:40:21 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=1c2709b1f3f0 ***

net: add test cases for the both of netgo, cgo DNS lookups

Update issue 4078

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/14638043

https://codereview.appspot.com/14638043/diff/56001/src/pkg/net/cgo_unix_test.go
File src/pkg/net/cgo_unix_test.go (right):

https://codereview.appspot.com/14638043/diff/56001/src/pkg/net/cgo_unix_test....
src/pkg/net/cgo_unix_test.go:12: func TestCGoLookupIP(t *testing.T) {
On 2013/12/18 18:02:46, rsc wrote:
> s/CGo/Cgo/

Done.

https://codereview.appspot.com/14638043/diff/56001/src/pkg/net/netgo_unix_tes...
File src/pkg/net/netgo_unix_test.go (right):

https://codereview.appspot.com/14638043/diff/56001/src/pkg/net/netgo_unix_tes...
src/pkg/net/netgo_unix_test.go:12: func TestNetGoLookupIP(t *testing.T) {
On 2013/12/18 18:02:46, rsc wrote:
> s/Net//

Done.

Expand All Messages | Collapse All Messages