Issue 14602043: code review 14602043: cmd/cgo: add wrappers for C.calloc and C.realloc, just ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14602043: code review 14602043: cmd/cgo: add wrappers for C.calloc and C.realloc, just ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Dominik Honnef

Modified:
10 years, 6 months ago

Reviewers:
rsc, iant

CC:
golang-dev

Visibility:
Public.

cmd/cgo: add wrappers for C.calloc and C.realloc, just like C.malloc Fixes issue 6506.

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -5 lines)			Patch
M	src/cmd/cgo/ast.go	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1 2 3	6 chunks	+50 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/cgo/callbacks.c	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
M	src/pkg/runtime/cgo/gcc_util.c	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgocall.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgocall.c	View	1	3 chunks	+39 lines, -1 line	0 comments	Download

Total messages: 4

Dominik Honnef

Hello r@golang.org, iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-10-10 20:33:44 UTC) #1

iant

We just got a report for memcpy at http://golang.org/issue/6575 . It doesn't make sense to ...

10 years, 6 months ago (2013-10-13 03:39:07 UTC) #2

*** Abandoned ***