Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(473)

Issue 145820044: code review 145820044: encoding/json: Marshal should use the last available va...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by oneofone
Modified:
9 years, 3 months ago
Reviewers:
rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

encoding/json: Marshal should use the last available value of duplicates instead of deleting the field While the spec doesn't specify what to do with duplicate keys, most implementations (V8, Python) will just use the last available value instead of deleting the key all together. Updated the tests for the change and added the test case from 8121. *I accidently abandoned 102030043* Fixes issue 8121.

Patch Set 1 #

Patch Set 2 : diff -r 6b163ec2122a172030284060788f535ab3b9d0e3 https://code.google.com/p/go #

Patch Set 3 : diff -r 6b163ec2122a172030284060788f535ab3b9d0e3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M src/encoding/json/decode_test.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/encoding/json/encode.go View 1 2 chunks +3 lines, -8 lines 0 comments Download
M src/encoding/json/encode_test.go View 1 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 3
oneofone
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2014-09-17 13:46:11 UTC) #1
rsc
not lgtm will comment on issue
9 years, 5 months ago (2014-10-06 18:38:26 UTC) #2
gobot
9 years, 3 months ago (2014-12-19 05:13:31 UTC) #3
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/145820044 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b