Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4743)

Issue 145710043: code review 145710043: time: A Timer must be properly created before use (docu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by gri
Modified:
9 years, 6 months ago
Reviewers:
bradfitz
CC:
rsc, bradfitz, golang-codereviews
Visibility:
Public.

Description

time: A Timer must be properly created before use (documentation). Fixes issue 8776.

Patch Set 1 #

Patch Set 2 : diff -r 0cc9f49292a7e63727bc9afb3883abdc4c52f39a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0cc9f49292a7e63727bc9afb3883abdc4c52f39a https://code.google.com/p/go/ #

Patch Set 4 : diff -r 0cc9f49292a7e63727bc9afb3883abdc4c52f39a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/time/sleep.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2014-10-01 23:42:33 UTC) #1
bradfitz
LGTM On Wed, Oct 1, 2014 at 4:42 PM, <gri@golang.org> wrote: > Reviewers: rsc, > ...
9 years, 6 months ago (2014-10-01 23:43:19 UTC) #2
gri
9 years, 6 months ago (2014-10-01 23:44:55 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=87dcbcc9371b ***

time: A Timer must be properly created before use (documentation).

Fixes issue 8776.

LGTM=bradfitz
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/145710043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b