Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(600)

Issue 14566048: code review 14566048: go.blog/cover: new article about test coverage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by r
Modified:
10 years, 3 months ago
Reviewers:
CC:
adg
Visibility:
Public.

Description

go.blog/cover: new article about test coverage

Patch Set 1 #

Patch Set 2 : diff -r 9da02ea712ec https://code.google.com/p/go.blog #

Total comments: 6

Patch Set 3 : diff -r 9da02ea712ec https://code.google.com/p/go.blog #

Patch Set 4 : diff -r 7d2b5822027b https://code.google.com/p/go.blog #

Patch Set 5 : diff -r 7d2b5822027b https://code.google.com/p/go.blog #

Patch Set 6 : diff -r 7d2b5822027b https://code.google.com/p/go.blog #

Patch Set 7 : diff -r bedf4f43741b https://code.google.com/p/go.blog #

Patch Set 8 : diff -r bedf4f43741b https://code.google.com/p/go.blog #

Patch Set 9 : diff -r bedf4f43741b https://code.google.com/p/go.blog #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -0 lines) Patch
A content/cover.article View 1 2 3 4 5 6 7 8 1 chunk +299 lines, -0 lines 1 comment Download
A content/cover/count.png View Binary file 0 comments Download
A content/cover/pkg.cover View 1 chunk +49 lines, -0 lines 0 comments Download
A content/cover/pkg.go View 1 chunk +17 lines, -0 lines 0 comments Download
A content/cover/pkg_test.go View 1 1 chunk +22 lines, -0 lines 0 comments Download
A content/cover/set.png View 1 Binary file 0 comments Download

Messages

Total messages: 7
r
Hello adg, I'd like you to review this change to https://code.google.com/p/go.blog
10 years, 7 months ago (2013-10-10 22:03:13 UTC) #1
adg
Looks good https://codereview.appspot.com/14566048/diff/5001/content/cover.article File content/cover.article (right): https://codereview.appspot.com/14566048/diff/5001/content/cover.article#newcode30 content/cover.article:30: Go is not a simple language, but ...
10 years, 7 months ago (2013-10-12 08:01:27 UTC) #2
r
All addressed and new version uploaded. It can probably sit until we're ready to launch ...
10 years, 7 months ago (2013-10-14 18:12:22 UTC) #3
adg
Ready to go with this, this week? https://codereview.appspot.com/14566048/diff/51002/content/cover.article File content/cover.article (right): https://codereview.appspot.com/14566048/diff/51002/content/cover.article#newcode2 content/cover.article:2: 14 Nov ...
10 years, 5 months ago (2013-12-02 05:20:30 UTC) #4
r
it's ready. feel free to submit when you want it to land. On Sun, Dec ...
10 years, 5 months ago (2013-12-02 06:28:00 UTC) #5
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=b1bdd3bd1144&repo=blog *** go.blog/cover: new article about test coverage R=adg https://codereview.appspot.com/14566048 Committer: Andrew ...
10 years, 5 months ago (2013-12-02 20:59:04 UTC) #6
r
10 years, 3 months ago (2014-01-23 23:43:21 UTC) #7
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b