Issue 145600044: code review 145600044: log/syslog: try /var/run/log, for FreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 145600044: code review 145600044: log/syslog: try /var/run/log, for FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant, bradfitz

Visibility:
Public.

Description

log/syslog: try /var/run/log, for FreeBSD Fixes issue 8449.

Patch Set 1 #

Patch Set 2 : diff -r cd24f5ff3db869a41efbf3a83e9e3f55b61460b8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f804c5bc096d3a87bba0dd7ed74aae850b93873e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4d7888400e99673e93b0187ba0a57a3aeb747d9a https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/log/syslog/syslog_unix.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: bradfitz), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-30 16:08:43 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=8cb7f59e4f1b *** log/syslog: try /var/run/log, for FreeBSD Fixes issue 8449. LGTM=iant R=golang-codereviews, ...

9 years, 7 months ago (2014-09-30 16:30:21 UTC) #3

gobot

9 years, 7 months ago (2014-09-30 17:39:00 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/cbfe4e8bbe2ee8ce151e799352fdbe64476dffa7

Expand All Messages | Collapse All Messages