Issue 145600043: code review 145600043: go.image/vp8: clamp the UV DC quantization factor to 132.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 145600043: code review 145600043: go.image/vp8: clamp the UV DC quantization factor to 132. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 7 months ago

Reviewers:
r, skal

CC:
r, skal, golang-codereviews

Visibility:
Public.

Description

go.image/vp8: clamp the UV DC quantization factor to 132. This fixes the lossy_extreme_probabilities.webp conformance test.

Patch Set 1 #

Patch Set 2 : diff -r 7886cae12d15437f47bb6ea9ef9150a87e48ef9c https://code.google.com/p/go.image #

Patch Set 3 : diff -r 7886cae12d15437f47bb6ea9ef9150a87e48ef9c https://code.google.com/p/go.image #

Patch Set 4 : diff -r 7886cae12d15437f47bb6ea9ef9150a87e48ef9c https://code.google.com/p/go.image #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	vp8/quant.go	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-codereviews@googlegroups.com, pascal.massimino@gmail.com), I'd like you to review this change to https://code.google.com/p/go.image

9 years, 7 months ago (2014-09-30 07:37:04 UTC) #1

nigeltao

9 years, 7 months ago (2014-09-30 23:40:03 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=9d31e3583c83&repo=image ***

go.image/vp8: clamp the UV DC quantization factor to 132.

This fixes the lossy_extreme_probabilities.webp conformance test.

LGTM=pascal.massimino, r
R=r, pascal.massimino
CC=golang-codereviews
https://codereview.appspot.com/145600043

Expand All Messages | Collapse All Messages