Issue 14526053: code review 14526053: go.tools/cmd/godoc: search go.tools/cmd for command docs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14526053: code review 14526053: go.tools/cmd/godoc: search go.tools/cmd for command docs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by adg

Modified:
10 years, 6 months ago

Reviewers:
dsymonds, rsc

CC:
r, dsymonds, golang-dev

Visibility:
Public.

Description

go.tools/cmd/godoc: search go.tools/cmd for command docs Update issue 6527

Patch Set 2 : diff -r 158101b21c6c https://code.google.com/p/go.tools #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	cmd/godoc/main.go	View		2 chunks	+7 lines, -2 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 6 months ago (2013-10-11 01:03:11 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=ee6380b173d1&repo=tools *** go.tools/cmd/godoc: search go.tools/cmd for command docs Update issue 6527 R=r, ...

10 years, 6 months ago (2013-10-11 01:36:58 UTC) #3

rsc

https://codereview.appspot.com/14526053/diff/5001/cmd/godoc/main.go File cmd/godoc/main.go (right): https://codereview.appspot.com/14526053/diff/5001/cmd/godoc/main.go#newcode387 cmd/godoc/main.go:387: // Try go.tools/cmd if not found in $GOROOT/cmd. I ...

10 years, 6 months ago (2013-10-15 15:16:55 UTC) #4

adg

10 years, 6 months ago (2013-10-15 22:54:37 UTC) #5

I hadn't thought about that. I agree. I'll send a fix.


On 16 October 2013 00:16, <rsc@golang.org> wrote:

>
>
https://codereview.appspot.**com/14526053/diff/5001/cmd/**godoc/main.go<https...
> File cmd/godoc/main.go (right):
>
> https://codereview.appspot.**com/14526053/diff/5001/cmd/**
>
godoc/main.go#newcode387<https://codereview.appspot.com/14526053/diff/5001/cmd/godoc/main.go#newcode387>
> cmd/godoc/main.go:387: // Try go.tools/cmd if not found in $GOROOT/cmd.
> I think this is backward. If someone does 'go get' godoc, then 'godoc
> godoc' should show the new docs, not the old ones.
> That is, go.tools/cmd should override local cmd for these tools, which
> is only a fallback.
>
>
https://codereview.appspot.**com/14526053/<https://codereview.appspot.com/145...
>

Expand All Messages | Collapse All Messages