Issue 14523054: code review 14523054: go.tools/importer: honor the client's TypeChecker.{Impo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14523054: code review 14523054: go.tools/importer: honor the client's TypeChecker.{Impo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by adonovan

Modified:
10 years, 6 months ago

Reviewers:
gri

CC:
gri, golang-dev

Visibility:
Public.

Description

go.tools/importer: honor the client's TypeChecker.{Import,Error} values. This requires us to make a copy of (not clobber) the supplied config, and retain their Import hook separately so that it can be wrapped by Importer.doImport. Fixes bug 6562.

Patch Set 1 #

Patch Set 2 : diff -r 7acf33aa0902 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 7acf33aa0902 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 8a0b7af1966c https://code.google.com/p/go.tools #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
	M	importer/importer.go	View	1 2	4 chunks	+20 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 6 months ago (2013-10-10 17:29:20 UTC) #1

adonovan

10 years, 6 months ago (2013-10-10 17:34:26 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=5efc87c3e8ea&repo=tools ***

go.tools/importer: honor the client's TypeChecker.{Import,Error} values.

This requires us to make a copy of (not clobber) the supplied
config, and retain their Import hook separately so that it can
be wrapped by Importer.doImport.

Fixes bug 6562.

R=gri
CC=golang-dev
https://codereview.appspot.com/14523054

Expand All Messages | Collapse All Messages