Issue 1452041: code review 1452041: Correct the regexp for finding unix signal names.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1452041: code review 1452041: Correct the regexp for finding unix signal names. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Raj_

Modified:
14 years, 9 months ago

Reviewers:

CC:
iant, golang-dev, golang-nuts_googlegroups.com, joel.sherrill

Visibility:
Public.

Description

Correct the regexp for finding unix signal names. For example, earlier, the regexp would accept SIGQUEUE_MAX as a unix signal with name SIGQUEUE. Now it is ignored.

Patch Set 1 #

Patch Set 2 : code review 1452041: Correct the regexp for finding unix signal names. #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/os/signal/mkunix.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Raj_

Hello iant (cc: golang-dev@googlegroups.com, golang-nuts@googlegroups.com, joel.sherrill), I'd like you to review this change.

14 years, 9 months ago (2010-06-01 18:29:04 UTC) #1

iant

14 years, 9 months ago (2010-06-01 19:02:07 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=818d49a26fb8 ***

	Correct the regexp for finding unix signal names.
  For example, earlier, the regexp would accept SIGQUEUE_MAX
  as a unix signal with name SIGQUEUE. Now it is ignored.

R=iant
CC=golang-dev, golang-nuts, joel.sherrill
http://codereview.appspot.com/1452041

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages