Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1206)

Issue 14516055: code review 14516055: cmd/gc: do not typecheck nil types in multiple assignment (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by Dominik Honnef
Modified:
10 years, 2 months ago
Reviewers:
DMorsing, rsc
CC:
golang-codereviews, bradfitz, minux1, iant, rsc, gobot, DMorsing
Visibility:
Public.

Description

cmd/gc: do not typecheck nil types in multiple assignment Fixes issue 6572.

Patch Set 1 #

Patch Set 2 : diff -r 47b2b07a837f https://code.google.com/p/go #

Patch Set 3 : diff -r 47b2b07a837f https://code.google.com/p/go #

Patch Set 4 : diff -r 47b2b07a837f https://code.google.com/p/go #

Patch Set 5 : diff -r 47b2b07a837f https://code.google.com/p/go #

Patch Set 6 : diff -r 47b2b07a837f https://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/cmd/gc/typecheck.c View 1 1 chunk +1 line, -1 line 0 comments Download
A test/fixedbugs/issue6572.go View 1 2 3 4 5 1 chunk +17 lines, -0 lines 1 comment Download

Messages

Total messages: 15
Dominik Honnef
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 5 months ago (2013-10-12 12:47:37 UTC) #1
bradfitz
No test? On Oct 12, 2013 2:47 AM, <dominik.honnef@gmail.com> wrote: > Reviewers: golang-dev1, > > ...
10 years, 5 months ago (2013-10-12 15:44:26 UTC) #2
Dominik Honnef
Sorry. PTAL. I hope the test's done right.
10 years, 5 months ago (2013-10-12 16:10:33 UTC) #3
minux1
have you tried the gccgo compiler? we also need to match the output of gccgo ...
10 years, 5 months ago (2013-10-12 19:48:02 UTC) #4
Dominik Honnef
Oh. No, I haven't. To be honest I have never set up a working gccgo ...
10 years, 5 months ago (2013-10-12 19:49:23 UTC) #5
iant
On Sat, Oct 12, 2013 at 12:49 PM, <dominik.honnef@gmail.com> wrote: > Oh. No, I haven't. ...
10 years, 5 months ago (2013-10-12 20:28:01 UTC) #6
Dominik Honnef
Done. The only discrepancy is line 9, for which gc has an error but gccgo ...
10 years, 5 months ago (2013-10-12 21:14:03 UTC) #7
rsc
not lgtm I'm sorry, but not before Go 1.2. I started down this path with ...
10 years, 5 months ago (2013-10-15 15:28:53 UTC) #8
Dominik Honnef
No worries, I'll gladly resend it after 1.2 – Or abandon it in case someone ...
10 years, 5 months ago (2013-10-15 15:31:07 UTC) #9
gobot
Replacing golang-dev with golang-codereviews.
10 years, 3 months ago (2013-12-20 16:26:05 UTC) #10
gobot
R=rsc@golang.org (assigned by bradfitz@golang.org)
10 years, 2 months ago (2014-01-09 21:15:59 UTC) #11
Dominik Honnef
PTAL
10 years, 2 months ago (2014-01-10 14:28:10 UTC) #12
DMorsing
LGTM This can't cause more code to go through to compile since the original error ...
10 years, 2 months ago (2014-01-16 16:05:38 UTC) #13
rsc
LGTM Thanks. https://codereview.appspot.com/14516055/diff/12002/test/fixedbugs/issue6572.go File test/fixedbugs/issue6572.go (right): https://codereview.appspot.com/14516055/diff/12002/test/fixedbugs/issue6572.go#newcode2 test/fixedbugs/issue6572.go:2: missing copyright notice. i will add it
10 years, 2 months ago (2014-01-22 03:27:31 UTC) #14
rsc
10 years, 2 months ago (2014-01-22 03:44:58 UTC) #15
*** Submitted as https://code.google.com/p/go/source/detail?r=1c81d22b1b60 ***

cmd/gc: do not typecheck nil types in multiple assignment

Fixes issue 6572.

LGTM=rsc, daniel.morsing, rsc
R=golang-codereviews, bradfitz, minux.ma, iant, rsc, gobot, daniel.morsing
CC=golang-codereviews
https://codereview.appspot.com/14516055

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b