Hello adg@golang.org, kevlar@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour
9 years, 7 months ago
(2014-09-19 02:20:31 UTC)
#1
Codemirror needs indentUnit and tabSize to match so indentWithTabs is taken into account. As weird ...
9 years, 7 months ago
(2014-09-19 02:48:12 UTC)
#3
Codemirror needs indentUnit and tabSize to match so indentWithTabs is taken
into account.
As weird as it seems.
On Thu, Sep 18, 2014 at 7:37 PM, <adg@golang.org> wrote:
> The change description doesn't match what the code seems to be doing. Is
> this change not just setting the tab width?
>
> https://codereview.appspot.com/145160043/
>
--
--
Francesc Campoy
http://twitter.com/francesc
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=46c5a004b207 *** go-tour: use tabs for indentation LGTM=adg R=adg, kevlar CC=golang-codereviews https://codereview.appspot.com/145160043
9 years, 7 months ago
(2014-09-19 06:14:17 UTC)
#5
Issue 145160043: code review 145160043: go-tour: use tabs for indentation
(Closed)
Created 9 years, 7 months ago by francesc
Modified 9 years, 7 months ago
Reviewers:
Base URL:
Comments: 0