Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3727)

Issue 145160043: code review 145160043: go-tour: use tabs for indentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by francesc
Modified:
9 years, 7 months ago
Reviewers:
adg
CC:
adg, kevlar, golang-codereviews
Visibility:
Public.

Description

go-tour: use tabs for indentation

Patch Set 1 #

Patch Set 2 : diff -r 18291d79a95f1c759e6f6ff2db35cdde5619640c https://code.google.com/p/go-tour #

Patch Set 3 : diff -r 18291d79a95f1c759e6f6ff2db35cdde5619640c https://code.google.com/p/go-tour #

Patch Set 4 : diff -r 18291d79a95f1c759e6f6ff2db35cdde5619640c https://code.google.com/p/go-tour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M static/js/values.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
francesc
Hello adg@golang.org, kevlar@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour
9 years, 7 months ago (2014-09-19 02:20:31 UTC) #1
adg
The change description doesn't match what the code seems to be doing. Is this change ...
9 years, 7 months ago (2014-09-19 02:37:58 UTC) #2
francesc
Codemirror needs indentUnit and tabSize to match so indentWithTabs is taken into account. As weird ...
9 years, 7 months ago (2014-09-19 02:48:12 UTC) #3
adg
LGTM
9 years, 7 months ago (2014-09-19 02:49:13 UTC) #4
francesc
9 years, 7 months ago (2014-09-19 06:14:17 UTC) #5
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=46c5a004b207
***

go-tour: use tabs for indentation

LGTM=adg
R=adg, kevlar
CC=golang-codereviews
https://codereview.appspot.com/145160043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b