Issue 14494051: code review 14494051: go.tools/importer: expose CreatePackage method.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14494051: code review 14494051: go.tools/importer: expose CreatePackage method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by adonovan

Modified:
10 years, 6 months ago

Reviewers:
gri

CC:
gri, golang-dev

Visibility:
Public.

Description

go.tools/importer: expose CreatePackage method. The new method is functionally identical to typeCheck, and obviates the LoadMainPackage method. Updated all clients. Fixes bug 6561.

Patch Set 1 #

Patch Set 2 : diff -r 688e88455980 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 688e88455980 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 688e88455980 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r c83d8928c3db https://code.google.com/p/go.tools #

Patch Set 6 : diff -r c83d8928c3db https://code.google.com/p/go.tools #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -33 lines)			Patch
M	importer/importer.go	View	1 2 3 4	6 chunks	+10 lines, -22 lines	0 comments	Download
M	importer/source_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pointer/example_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pointer/pointer_test.go	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ssa/builder_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ssa/example_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ssa/interp/interp_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ssa/source_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 6 months ago (2013-10-10 16:24:52 UTC) #1

adonovan

10 years, 6 months ago (2013-10-10 16:37:51 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=767976906cd7&repo=tools ***

go.tools/importer: expose CreatePackage method.

The new method is functionally identical to typeCheck, and
obviates the LoadMainPackage method.

Updated all clients.

Fixes bug 6561.

R=gri
CC=golang-dev
https://codereview.appspot.com/14494051

Expand All Messages | Collapse All Messages