code review 144870045: cmd/ld: document that -X overwrites initialized variables

cmd/ld: document that -X overwrites initialized variables

Fixes issue 7626.

[josharian, 2014-09-15 17:58:33]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[josharian, 2014-09-15 17:58:52]

The discussion in the issue left open whether to alter the behavior or the
documentation. The current behavior is useful; let's document.

[iant, 2014-09-16 00:48:16]

No good deed goes unpunished: please add a test case for this. See test/linkx.go
for how to test -X.  Actually you can probably just extend that test.

Note that that test is one of the few that is not run by src/run.bash.  It is
run by test/run, though.

[josharian, 2014-09-16 01:05:07]

> No good deed goes unpunished: please add a test case for this.

This kind of punishment I can handle. :)

PTAL

[iant, 2014-09-16 01:13:11]

LGTM

Thanks.

[josharian, 2014-09-16 01:16:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=b18ebcb9f236 ***

cmd/ld: document that -X overwrites initialized variables

Fixes issue 7626.

LGTM=iant
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/144870045