Issue 14484043: code review 14484043: go.tools/cmd/vet: Update canonical method check for new...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14484043: code review 14484043: go.tools/cmd/vet: Update canonical method check for new... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Dominik Honnef

Modified:
10 years, 6 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

go.tools/cmd/vet: Update canonical method check for new xml.Marshaler/Unmarshaler interfaces

Patch Set 1 #

Patch Set 2 : diff -r 46a5b05299b4 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 46a5b05299b4 https://code.google.com/p/go.tools #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
	M	cmd/vet/method.go	View	1	1 chunk	+13 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Dominik Honnef

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 6 months ago (2013-10-07 09:09:25 UTC) #1

10 years, 6 months ago (2013-10-07 18:10:39 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=b01566446629&repo=tools ***

go.tools/cmd/vet: Update canonical method check for new
xml.Marshaler/Unmarshaler interfaces

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/14484043

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages