Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3587)

Issue 144610043: code review 144610043: [release-branch.go1.3] net/http/httptest: disable TestI... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by rsc
Modified:
9 years, 6 months ago
Reviewers:
gobot, bradfitz
CC:
bradfitz, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] net/http/httptest: disable TestIssue7264 This fails on my OS X machine, just like it did in default branch. In the default branch we removed the test. It's just buggy.

Patch Set 1 #

Patch Set 2 : diff -r 4b852be63380 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4b852be63380 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4b852be63380 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/net/http/httptest/server_test.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello bradfitz (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2014-09-25 18:12:46 UTC) #1
bradfitz
LGTM On Thu, Sep 25, 2014 at 11:12 AM, <rsc@golang.org> wrote: > Reviewers: bradfitz, > ...
9 years, 6 months ago (2014-09-25 18:13:23 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=3106a8c415f2 *** [release-branch.go1.3] net/http/httptest: disable TestIssue7264 This fails on my OS X ...
9 years, 6 months ago (2014-09-25 18:14:20 UTC) #3
gobot
9 years, 6 months ago (2014-09-29 03:32:40 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/5f2f0517588eda88f5bae79acf99ed8918ecf68e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b