Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2498)

Issue 144540044: code review 144540044: fmt: document and fix the handling of precision for str... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by r
Modified:
9 years, 6 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

fmt: document and fix the handling of precision for strings and byte slices Previous behavior was undocumented and inconsistent. Now it is documented and consistent and measures the input size, since that makes more sense when talking about %q and %x. For %s the change has no effect. Fixes issue 8151.

Patch Set 1 #

Patch Set 2 : diff -r 2f66d595a9ec50db3bf4fe871c6a25a5fff21df3 https://code.google.com/p/go #

Patch Set 3 : diff -r 12a2c798d360d887b5899bf09b31a56ed6a70823 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M src/fmt/doc.go View 1 1 chunk +12 lines, -8 lines 0 comments Download
M src/fmt/fmt_test.go View 1 chunk +7 lines, -0 lines 0 comments Download
M src/fmt/format.go View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2014-09-24 21:09:16 UTC) #1
iant
LGTM
9 years, 7 months ago (2014-09-24 21:20:43 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=5cd2307cc287 *** fmt: document and fix the handling of precision for strings ...
9 years, 7 months ago (2014-09-24 21:33:35 UTC) #3
gobot
9 years, 6 months ago (2014-09-26 00:55:07 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64-perf builder.
See http://build.golang.org/log/94925ade52662489a8f518095d5ef04ac04dae25
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b