Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(358)

Issue 144420043: code review 144420043: fmt: document that self-recursive data structures can b... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by r
Modified:
9 years, 6 months ago
Reviewers:
iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

fmt: document that self-recursive data structures can be fatal Fixes issue 8241.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 21a183839336b441cacbc7974aeb58efeed53794 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 21a183839336b441cacbc7974aeb58efeed53794 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/fmt/doc.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2014-09-22 21:27:13 UTC) #1
iant
LGTM https://codereview.appspot.com/144420043/diff/1/src/fmt/doc.go File src/fmt/doc.go (right): https://codereview.appspot.com/144420043/diff/1/src/fmt/doc.go#newcode150 src/fmt/doc.go:150: Fatal recursion can also be triggered by self-referential ...
9 years, 6 months ago (2014-09-22 21:49:22 UTC) #2
r
Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 6 months ago (2014-09-22 22:08:50 UTC) #3
iant
LGTM
9 years, 6 months ago (2014-09-22 22:09:40 UTC) #4
r
9 years, 6 months ago (2014-09-22 22:35:28 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=7809e33f731b ***

fmt: document that self-recursive data structures can be fatal

Fixes issue 8241.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/144420043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b