Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 14438065: code review 14438065: net/http: flush request body chunks to the wire.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by benburkert
Modified:
10 years ago
Visibility:
Public.

Description

net/http: flush request body chunks to the wire. Fixes issue 6574.

Patch Set 1 #

Patch Set 2 : diff -r 47b2b07a837f https://code.google.com/p/go #

Patch Set 3 : diff -r 47b2b07a837f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/pkg/net/http/chunked.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/net/http/chunked_test.go View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13
benburkert
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 5 months ago (2013-10-12 20:59:10 UTC) #1
dsymonds
This seems like it would reduce the performance of servers that don't care about your ...
10 years, 5 months ago (2013-10-12 21:48:52 UTC) #2
benburkert
For server response writing chunks over 4096 (bufio.defaultBufSize) bytes, the extra overhead will be the ...
10 years, 5 months ago (2013-10-12 22:14:06 UTC) #3
dsymonds
I'm thinking about all the small writes. Your change is effectively removing the buffering entirely, ...
10 years, 5 months ago (2013-10-12 22:24:45 UTC) #4
benburkert
Yes, that is correct. But my guess is that there are not many servers that ...
10 years, 5 months ago (2013-10-12 22:46:28 UTC) #5
minux1
On Sat, Oct 12, 2013 at 6:46 PM, <ben@benburkert.com> wrote: > Yes, that is correct. ...
10 years, 5 months ago (2013-10-12 22:53:34 UTC) #6
benburkert
Could you please expand upon this? As I understand it there is no way for ...
10 years, 5 months ago (2013-10-12 23:12:59 UTC) #7
bradfitz
I replied at https://code.google.com/p/go/issues/detail?id=6574 Let's discuss there, but ideally after Go 1.2 is out. On ...
10 years, 5 months ago (2013-10-12 23:31:52 UTC) #8
gobot
Replacing golang-dev with golang-codereviews.
10 years, 3 months ago (2013-12-20 16:26:11 UTC) #9
gobot
Replacing golang-dev with golang-codereviews.
10 years, 3 months ago (2013-12-20 16:26:11 UTC) #10
gobot
R=bradfitz@golang.org (assigned by dsymonds@golang.org)
10 years, 2 months ago (2014-01-03 00:46:40 UTC) #11
bradfitz
This isn't the right place to fix it. Doing it here means a normal io.Copy ...
10 years, 2 months ago (2014-01-03 17:44:39 UTC) #12
rsc
10 years ago (2014-03-05 20:01:01 UTC) #13
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b