Issue 14432053: code review 14432053: cmd/gc: re-word some error messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14432053: code review 14432053: cmd/gc: re-word some error messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by minux1

Modified:
10 years, 6 months ago

Reviewers:
rsc

CC:
golang-dev, rsc, btracey

Visibility:
Public.

Description

cmd/gc: re-word some error messages Fixes issue 6557.

Patch Set 2 : diff -r 3f38e968e072 https://code.google.com/p/go #

Patch Set 3 : diff -r 3f38e968e072 https://code.google.com/p/go #

Patch Set 4 : diff -r 3f38e968e072 https://code.google.com/p/go #

Total comments: 5

Patch Set 5 : diff -r 84f56bb7013a https://code.google.com/p/go #

Patch Set 6 : diff -r 84f56bb7013a https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/cmd/gc/dcl.c	View	1 2 3 4	5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-10-10 01:31:06 UTC) #1

rsc

LGTM https://codereview.appspot.com/14432053/diff/9001/src/cmd/gc/dcl.c File src/cmd/gc/dcl.c (right): https://codereview.appspot.com/14432053/diff/9001/src/cmd/gc/dcl.c#newcode292 src/cmd/gc/dcl.c:292: yyerror("missing expression in variable declaration"); s/variable/var/ (keep go ...

10 years, 6 months ago (2013-10-10 14:36:26 UTC) #2

btracey

How does one trigger the - yyerror("missing expr in const dcl"); + yyerror("missing value in ...

10 years, 6 months ago (2013-10-10 16:16:52 UTC) #3

minux1

*** Submitted as https://code.google.com/p/go/source/detail?r=062f1f0ea8ba *** cmd/gc: re-word some error messages Fixes issue 6557. R=golang-dev, rsc, ...

10 years, 6 months ago (2013-10-11 02:43:41 UTC) #4

minux1

10 years, 6 months ago (2013-10-11 02:46:45 UTC) #5

On Thu, Oct 10, 2013 at 12:16 PM, <tracey.brendan@gmail.com> wrote:

> How does one trigger the
> -                        **yyerror("missing expr in const dcl");
> +                        **yyerror("missing value in constant
> declaration");
>
> error? That error message sounds vague to me, but maybe it isn't in
> context.
>
http://play.golang.org/p/gbJFqYLOFz

const a, b = 1

i think the msg is clear in this context.

Expand All Messages | Collapse All Messages