code review 144070044: net: disable TestDialMultiFDLeak

net: disable TestDialMultiFDLeak

It fails about 25% of the time on OS X.
I don't know what it's trying to do.
Created issue 8764 to correct this, but for now disable.

[rsc, 2014-09-17 21:08:52]

Hello bradfitz (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-09-17 21:35:10]

LGTM


On Wed, Sep 17, 2014 at 5:08 PM, <rsc@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net: disable TestDialMultiFDLeak
>
> It fails about 25% of the time on OS X.
> I don't know what it's trying to do.
> Created issue 8764 to correct this, but for now disable.
>
> Please review this at https://codereview.appspot.com/144070044/
>
> Affected files (+2, -0 lines):
>   M src/net/dial_test.go
>
>
> Index: src/net/dial_test.go
> ===================================================================
> --- a/src/net/dial_test.go
> +++ b/src/net/dial_test.go
> @@ -339,6 +339,8 @@
>  }
>
>  func TestDialMultiFDLeak(t *testing.T) {
> +       t.Skip("flaky test - golang.org/issue/8764")
> +
>         if !supportsIPv4 || !supportsIPv6 {
>                 t.Skip("neither ipv4 nor ipv6 is supported")
>         }
>
>
>

[mikio, 2014-09-18 06:21:59]

lgtm

https://codereview.appspot.com/144070044/diff/40001/src/net/dial_test.go
File src/net/dial_test.go (right):

https://codereview.appspot.com/144070044/diff/40001/src/net/dial_test.go#newc...
src/net/dial_test.go:342: t.Skip("flaky test - golang.org/issue/8764")
switch runtime.GOOS {
case "darwin":
         ...
}

[rsc, 2014-09-18 18:48:12]

i'm going to disable it for all systems.
if you know why the flake would be darwin-specific feel free to reenable.
in the absence of that evidence, it's just as likely flaky everywhere but
only the darwin builder has the right timing today.

[rsc, 2014-09-18 18:48:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=0b30efcfcb51 ***

net: disable TestDialMultiFDLeak

It fails about 25% of the time on OS X.
I don't know what it's trying to do.
Created issue 8764 to correct this, but for now disable.

LGTM=bradfitz, mikioh.mikioh
R=bradfitz, mikioh.mikioh
CC=golang-codereviews
https://codereview.appspot.com/144070044